frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
179 stars 101 forks source link

option to break inside table needed #15

Open SantoshSrinivas79 opened 12 months ago

SantoshSrinivas79 commented 12 months ago

Hello @maharshivpatel .... the generated PDF seems to have formatting issues shown below.

PDF screenshot

CleanShot 2023-07-02 at 14 30 26

The preview in the print designer shows up correctly. The Terms and Conditions field is the only field in the last page of the generated pdf.

Design preview is below:

CleanShot 2023-07-02 at 14 36 14

maharshivpatel commented 12 months ago

Please share pdf and

can you share your format like this :

You can paste the data here ( change any personal info )

https://github.com/frappe/print_designer/assets/39730881/b7b761c7-a2b1-43d4-a3b3-0dde25ba9699

SantoshSrinivas79 commented 12 months ago

Please see below:

{"name":"Job Offer - SRA - PD - 1","owner":"Administrator","creation":"2023-06-29 03:32:54.234367","modified":"2023-07-02 04:50:10.482213","modified_by":"Administrator","docstatus":0,"idx":0,"print_designer_after_table":"[{\"id\":\"ZKYpmffUey\",\"type\":\"text\",\"content\":\"\",\"contenteditable\":true,\"isDynamic\":true,\"isFixedSize\":true,\"dynamicContent\":[{\"doctype\":\"\",\"parentField\":\"\",\"fieldname\":\"terms\",\"value\":\"<div class=\\\"ql-editor read-mode\\\"><p>You shall be governed by the following terms and conditions of service during your internship with Silk Route Advisors LLP, and those may be amended from time to time.</p><p><br></p><p><br></p><p>All the work that you will produce at or in relation to Silk Route Advisors LLP will be the intellectual property of Silk Route Advisors LLP. You are not allowed to store, copy, sell, share, and distribute it to a third party under any circumstances. Similarly you are expected to refrain from talking about your work in public domains (both online such as blogging, social networking site and offline among your friends, college etc.) without prior discussion and approval with your mentor.</p><p><br></p><p>During the appointment period you shall not engage yourselves directly or indirectly or in any capacity in any other organization (other than your college). In the event of breach of this condition, this appointment is liable to be terminated forthwith by the company. In addition, you shall be liable to pay liquidated damages to the Company of an extent estimated by the Company.</p><p><br></p><p>Under normal circumstances either the company or you may terminate this association by providing a notice of 30 days without assigning any reason. However, the company may terminate this agreement forthwith under situations of in-disciplinary behaviours</p></div>\",\"fieldtype\":\"Text Editor\",\"label\":\"<b>Terms and Conditions :</b>\",\"is_labelled\":true,\"is_static\":false,\"style\":{},\"labelStyle\":{},
SantoshSrinivas79 commented 12 months ago

Any suggestions to resolve this @maharshivpatel?

maharshivpatel commented 12 months ago

please share pdf as well

SantoshSrinivas79 commented 12 months ago

Hi @maharshivpatel .. can I DM you the PDF on Telegram pl or email it?

SantoshSrinivas79 commented 12 months ago

Hi @maharshivpatel Any suggestion on how to fix this .. would be happy to do a Google meet if it help you debug :)

maharshivpatel commented 12 months ago

I understood the issue. thinking of how to fix this.

SantoshSrinivas79 commented 11 months ago

Any workarounds on this @maharshivpatel?

maharshivpatel commented 11 months ago

I haven't gotten time to work on this yet. so this is not a bug, you want to break inside row and some people don't. i am trying to figure out how to handle it so it works for both. there are some issues that come with breaking inside row.

maharshivpatel commented 2 months ago

@smthakor1979 please create new issue with details i think your issue is a bit different.