frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
180 stars 101 forks source link

Current Page, Total Pages, Print Date & Print Time not show #218

Closed bobotdls closed 2 months ago

bobotdls commented 2 months ago

Before I use the v.1 but the Current Page, Total Pages, Print Date & Print Time not show Then I see that you have a new version, I thought it was just a bugs, Right now I'am using v1.1.0 still same not showing Current Page, Total Pages, Print Date & Print Time not show

maharshivpatel commented 2 months ago

@bobotdls Current Page, Total Pages, Print Date & Print Time only shows if you they are in header / footer.

please make sure they are in header/footer area.

bobotdls commented 2 months ago

Yup they are in the footer but it's not show

hmb47 commented 2 months ago

the same issue

maharshivpatel commented 2 months ago

@bobotdls @hmb47 this started after upgrading to 1.1.0 ?

hmb47 commented 2 months ago

1.1.0 no, before 1.1.0

bobotdls commented 2 months ago

even before 1.1.0

bobotdls commented 2 months ago

but I remember on Frappe v. 14 before I still can use the page now I'am using v.15

bobotdls commented 2 months ago

ERPNext: v15.17.0 (version-15)

Frappe Framework: v15.17.3 (version-15)

Print Designer: v1.0.0 (main)

on that version above the Current Page, Total Pages, Print Date & Print Time is showing fine

but below version

ERPNext: v15.19.1 (version-15)

Frappe Framework: v15.20.0 (version-15)

Print Designer: v1.1.0 (main)

is not showing

maharshivpatel commented 2 months ago

sorry for the inconvenience this slipped through the recent refactor. fixed now will be available in the next week's release.

bobotdls commented 2 months ago

ok thanks

maharshivpatel commented 2 months ago

:tada: This issue has been resolved in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: