search

frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
214 stars 116 forks source link

fix: google font url generator edge case #235

Closed maharshivpatel closed 5 months ago

maharshivpatel commented 5 months ago

we save font details saved in json object and then we generate url from it using jinja template. there was a edge case where ; was not being added at the end of normal weight.

incorrect https://fonts.googleapis.com/css2?family=JetBrains%20Mono:ital,wght@0,400;0,5001,400

correct https://fonts.googleapis.com/css2?family=JetBrains%20Mono:ital,wght@0,400;0,500;1,400

maharshivpatel commented 5 months ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: