frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
179 stars 101 forks source link

Changing between fonts which have no corresponding weights, will result in app hang and crash. #269

Open PhantomKunai opened 1 month ago

PhantomKunai commented 1 month ago

If a font is set (with a particular weight say semi-bold) for sub-sections of a text box, and then the overall font of the textbox is changed to a different font which has no weight for semi-bold, the preview of the text shows the old font.

Attempting to change the font of the sub section will cause the app to hang.

https://github.com/frappe/print_designer/assets/12585952/1d858f46-c32a-457b-8880-e9cf69a6f809

PhantomKunai commented 1 month ago

Temporary workaround is to set the text box back to original font, change the weights to something common between new font and old font and then change the whole font of the box, or just change them individually.

Luckily this workaround works, or one would have to redo the whole format with the right font because there's no way to recover from the hang, not even refreshing.