search

frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
179 stars 101 forks source link

If no data is stored in text boxes, they should be deleted and not remain as elements in the format. #270

Open PhantomKunai opened 1 month ago

PhantomKunai commented 1 month ago

If no data is stored in text boxes, they should be deleted instead of being stored as 0 width and 0 height components on the format.

This will prevent awkward issues where a text box of 0 width and 0 height was created by mistake and is intersecting with the header boundary but is almost impossible to see on the format as highlighted in red.

  1. General view of the print format header section. There are two empty text boxes here which are not visible at all normally without selecting. image

  2. Attempting to save will throw this error as it intersects with header area image

  3. But the actual intersection is near impossible to see. It looks like nothing is there. image

  4. The actual intersection being highlighted image

PhantomKunai commented 1 month ago

This get really confusing to spot when there text all around it and the whole highlight is hidden in plain sight. Feels like Im playing Where's waldo on hard mode. 😂

maharshivpatel commented 1 month ago

@PhantomKunai i will add cleanup so if there is no text it will be deleted.