search

frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
179 stars 101 forks source link

Image not linked #279

Closed 2old4thisShit closed 5 days ago

2old4thisShit commented 3 weeks ago

Hello!

Since the print designer does not support a signature as a dynamic image (and I wouldn't know how to develop it at the moment), I've tried to solve the problem in another way:

I converted the stored signature into an image and stored it in an attached image field.

The image is stored correctly in the "firma_convertida" field and is also visible in "Files." But the print designer seems unable to find it, or at least it is not linked.

image

The image is recognized as a static image, but of course, I need it to display the corresponding signature for each doctype. image

Additionally, I've also found that when opening dynamic images for the first time, it doesn't find any linked ones. This only happens if, for example:

  1. I create a format
  2. I start editing it
  3. I add a dynamic image
  4. I save it
  5. I go back in
  6. I select a dynamic image

First open: image

Next open: image

Bench:

frappe 15.29.1 version-15 erpnext 15.27.0 version-15 xFl 0.2.0 develop (my custom app) print_designer 1.2.0 main webshop 0.0.1 develop

2old4thisShit commented 5 days ago

All this makes no sense after integrating the signatures in: https://github.com/frappe/print_designer/pull/298

So this issue can be closed.

Thanks again @maharshivpatel .