search

frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
221 stars 119 forks source link

replace wkhtmltopdf with chrome #329

Open maharshivpatel opened 3 months ago

maharshivpatel commented 3 months ago

for a while, I have been doing a lot of workarounds, limiting features of print designer etc because wkhtmltopdf doesn't support modern CSS.

Also, a lot of stuff breaks and there is no way to debug such as content broken between pages. e.g. div inside span is possible in Chrome ( modern ) browser but will automatically escape out of span in wkhtmltopdf.

There are a lot of such cases and I have realised that if I combine time spent on such workarounds plus more that I have to spend in the future is less than what I will spend replacing wkhtmltopdf.

This was on my list for almost a year so finally I will be working on it.

win8linux commented 1 month ago

As mentioned originally in https://github.com/frappe/frappe/issues/27595:

wkhtmltopdf has stopped development and its Git repo has been archived since 2023. Packages for it are beginning to fall behind that of Linux distributions, even with those that are not on a rolling release schedule. Additionally, having an unmaintained dependency that relies on a defunct QtWebKit web engine fork creates a large and porous attack surface.

rmcdonald01 commented 3 weeks ago

How will we be notified when the change to Chrome has been made?