frappe / print_designer

Visual print designer for Frappe / ERPNext
GNU Affero General Public License v3.0
179 stars 101 forks source link

Multiple Issues and Suggestions #80

Open yamenzk opened 7 months ago

yamenzk commented 7 months ago

Hello! First of all, amazing work on this. I was really surprised how capable this designer is in generating print formats that appear almost similarly in the designer, print and pdf. You can see below my work on a purchase order print format.

Screenshot_20231109_200605_Adobe Acrobat~2 In the screenshot shown above, you can see my first attempt in using the print designer and it looks great! However, I have had few issues and suggestions during the process and would like to share them below.

maharshivpatel commented 7 months ago

@yamenzk

can you share your format like this :

You can paste the data here ( change any personal info )

https://github.com/frappe/print_designer/assets/39730881/b7b761c7-a2b1-43d4-a3b3-0dde25ba9699

Comments on your points ( Issue 1 == Answer 1 )

  1. click on header/footer button and set it accordingly then it will not overlap ( Link ) .

  2. haven't added yet, will add

  3. There is a bug in Color control I will fix this ( If you share your format i can easily debug this ) Try to select Inner Text like this and change it a color .

  4. Same Issue as 3

  5. Didn't Understand Where is it not available

  6. Please Share Example for this

  7. Yeah, that is wkhtmltopdf related issue you need to disable border like this for now ( will improve feedback on icons for now click on icons and check if border goes away on table )

    Screenshot 2023-11-09 at 10 27 50 PM
  8. on my list ( you can duplicate by pressing alt and then just click and drag )

  9. Same as 3 will improve Color Control

  10. https://github.com/frappe/print_designer/issues/74

  11. Not supported by wkhtmltopdf ( library that generates pdf )

  12. Please Share more information

  13. That is possible, do you mean design multiple page print format https://github.com/frappe/print_designer/issues/23

  14. https://github.com/frappe/print_designer/issues/61

  15. Will add this

yamenzk commented 7 months ago

Currently away from my PC but I can't understand the solution to #1. So let's consider creating a purchase order document. The first section is company and supplier Second section is item order table (item, qty, rate, amount) Third section includes grand, net total, in words, etc..

For such example, the video you provided proposes a solution. However let's say I want to add another item table, now it includes specifications like image, description, brand, material type and other custom fields concerning and item specification. Then I want to add a payment terms table and/or a tax breakdown table

Where do I place these tables? Part of the footer?

yamenzk commented 7 months ago

I will reply to the rest as soon as I get back and I will share the format

maharshivpatel commented 7 months ago

Currently away from my PC but I can't understand the solution to #1.

So let's consider creating a purchase order document.

The first section is company and supplier

Second section is item order table (item, qty, rate, amount)

Third section includes grand, net total, in words, etc..

For such example, the video you provided proposes a solution.

However let's say I want to add another item table, now it includes specifications like image, description, brand, material type and other custom fields concerning and item specification.

Then I want to add a payment terms table and/or a tax breakdown table

Where do I place these tables? Part of the footer?

Yes, other elements that come after main table goes into footer ( this will repeat them on all pages ) if you don't want that you have to wait until i find a solution to introduce dynamic height containers

maharshivpatel commented 7 months ago

I will reply to the rest as soon as I get back and I will share the format

@yamenzk I look forward to it

SvbZ3r0 commented 6 months ago

@maharshivpatel

maharshivpatel commented 6 months ago

No 1. is solved by #107