frappe / twilio-integration

Twilio integration for ERPNext
Other
61 stars 74 forks source link

No module named 'pyngrok' #31

Closed gavindsouza closed 2 years ago

gavindsouza commented 2 years ago

pyngrok was a direct dependency of twilio-integration but wasn't added to requirements.txt. Since it was removed from frappe via https://github.com/frappe/frappe/commit/49b157e7e5f3945e5b4f5823cfce3e42c9a7fb93#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552, new setups/envs seem to be breaking with the following traceback:

Traceback (most recent call last):
  File "apps/frappe/frappe/email/doctype/notification/notification.py", line 398, in evaluate_alert
    alert = frappe.get_doc("Notification", alert)
  File "apps/frappe/frappe/__init__.py", line 898, in get_doc
    doc = frappe.model.document.get_doc(*args, **kwargs)
  File "apps/frappe/frappe/model/document.py", line 70, in get_doc
    controller = get_controller(doctype)
  File "apps/frappe/frappe/model/base_document.py", line 70, in get_controller
    site_controllers[doctype] = _get_controller()
  File "apps/frappe/frappe/model/base_document.py", line 48, in _get_controller
    module = frappe.get_module(module_path)
  File "apps/frappe/frappe/__init__.py", line 987, in get_module
    return importlib.import_module(modulename)
  File "/home/frappe/.pyenv/versions/3.9.9/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "apps/twilio_integration/twilio_integration/overrides/notification.py", line 4, in <module>
    from twilio_integration.twilio_integration.doctype.whatsapp_message.whatsapp_message import WhatsAppMessage
  File "apps/twilio_integration/twilio_integration/twilio_integration/__init__.py", line 1, in <module>
    from . import api
  File "apps/twilio_integration/twilio_integration/twilio_integration/api.py", line 6, in <module>
    from .twilio_handler import Twilio, IncomingCall, TwilioCallDetails
  File "apps/twilio_integration/twilio_integration/twilio_integration/twilio_handler.py", line 11, in <module>
    from .utils import get_public_url, merge_dicts
  File "apps/twilio_integration/twilio_integration/twilio_integration/utils.py", line 1, in <module>
    from pyngrok import ngrok
ModuleNotFoundError: No module named 'pyngrok'