search

frappe / wiki

Free and Open Source Wiki built on top of Frappe
https://frappe.io/wiki
MIT License
228 stars 181 forks source link

Sidebars and edit area not loaded correctly for user with System Admin and Wiki Approval role #127

Closed hatuan195 closed 1 year ago

hatuan195 commented 1 year ago

In our setup, clicking edit on a wiki page only ok for Administrator. Any other users even with System Admin and Wiki Approver roles only see blank edit page without sidebars like follow image

bench version output: education 0.0.1 erpnext 14.18.3 frappe 14.28.2 hrms 15.0.0-dev wiki 0.0.1

Do we need to set other roles?

image

BreadGenie commented 1 year ago

This is weird. The sidebar on /edit-wiki doesn't depend on permissions or roles afaik. I tried with both website user and system admin with wiki approval role and it works fine. This feels like wiki failed to fetch the root sidebar but that too doesn't depend on any roles.

I've created a telegram group for wiki support. Feel free to join the group and we can nail down this issue.

Alternatively we can debug the issue here What's the value returned by topmost(line 49) and sidebar_items(line 53) from https://github.com/frappe/wiki/blob/995f221444dea190f0f087844375c3c37ad9b0b4/wiki/wiki/doctype/wiki_sidebar/wiki_sidebar.py#L47-L55

BreadGenie commented 1 year ago

Closing since this isn't relevant after #124