search

frappe / wiki

Free and Open Source Wiki built on top of Frappe
https://frappe.io/wiki
MIT License
226 stars 174 forks source link

feature: Make sidebar items' links full-width #197

Closed jonathan-richer closed 9 months ago

jonathan-richer commented 9 months ago

In the hopes of fixing #196

I only added width: 100% to CSS selector .sidebar-item :first-child to expand the child <a> element.

This make the sidebar links consistent with the sidebar groups which are full-width as well as making it easier to navigate through the pages without having to think how long the title is.

I left the margin-right: auto, but by making the width: 100%, it removes the margin. There may be a situation where it is needed, but it seems very unlikely.

cypress[bot] commented 9 months ago

Passing run #254 ↗︎

0 5 0 0 Flakiness 0

Details:

Merge 859cb58b065c046312d96b5783a0ef944af92d12 into 2bc32db77c2596279786bd1247d9...
Project: Wiki Commit: d67c6a676c ℹ️
Status: Passed Duration: 00:26 💡
Started: Nov 22, 2023 6:39 PM Ended: Nov 22, 2023 6:40 PM

Review all test suite changes for PR #197 ↗︎