search

frappe / wiki

Free and Open Source Wiki built on top of Frappe
https://frappe.io/wiki
MIT License
219 stars 168 forks source link

Frappe Search Integration #215

Closed safwansamsudeen closed 5 months ago

safwansamsudeen commented 6 months ago

This integrates Frappe Search into Wiki.

The previous implementation also used website search. Is this necessary? If so, how will we implement it here?

(Will revert the formatting soon).

BreadGenie commented 6 months ago

The previous implementation also used website search. Is this necessary? If so, how will we implement it here?

We are using website search only as a fallback for when redisearch fails to work. It's better to remove both and maintain just one type of search for now.

cypress[bot] commented 6 months ago

Passing run #291 ↗︎

0 5 0 0 Flakiness 0

Details:

Merge 9fadf9b24fcd634bd4876bcfb58ba53facb382b1 into 3899e787aa094b8774738479e601...
Project: Wiki Commit: cd66c678e6 ℹ️
Status: Passed Duration: 00:19 💡
Started: Feb 11, 2024 12:08 PM Ended: Feb 11, 2024 12:08 PM

Review all test suite changes for PR #215 ↗︎

safwansamsudeen commented 5 months ago

Closing this PR as we move to a Python based implementation of Frappe Search. Also, we will first implement in Gameplan to get internal feedback before deploying to Wiki.