misc issues/feature requests - Githubissues

frappe / wiki

Free and Open Source Wiki built on top of Frappe

https://frappe.io/wiki

MIT License

219 stars 168 forks source link

misc issues/feature requests #221

Open phot0n opened 4 months ago

phot0n commented 4 months ago

feature to hide a group in the sidebar - should be straightforward from the backend (wiki space doctype) - would probably need some design effort from the front end (like in edit page/group thing, even the hidden groups will be visible so they can be unhidden)

#

the allow_guest feature should only make the pages visible in sidebar if the user is logged in - currently they are "visible" even when the user is guest

#

feature to add a sidebar group above/below a group directly from a particular sidebar group - currently new groups get added to the bottom?

#

clear wiki_sidebar cache upon wiki page's route updation - currently happens on title change or deletion of page

#

This checkbox is hella confusing - since it's before the dark logo button - i thought it's for asking if you want to add dark mode logo or not - apparently it's for showing the switch for dark/light theme for ui :sweat_smile: - also we can probably just show that switch by default on the UI? and do away with that checkbox?

phot0n commented 4 months ago

This is horrible:

https://github.com/frappe/wiki/blob/3899e787aa094b8774738479e60167fb6ba82a72/wiki/wiki/doctype/wiki_space/wiki_space.py#L43-L71

the route of all wiki pages is being destroyed here - which will essentially mean all the a tags which link to docs will also suffer - this needs to be removed or altered to only replace the old route prefix from the wiki pages route (that too with a warning)