search

frappe / wiki

Free and Open Source Wiki built on top of Frappe
https://frappe.io/wiki
MIT License
219 stars 168 forks source link

snapshot like wiki space cloning? #230

Open phot0n opened 4 months ago

phot0n commented 4 months ago

currently the wiki space is cloned in background which clones the page items in the space at the moment the clone job is run - which is fine but not really what my expectation was.

My Expectation: The moment I hit "Clone Wiki Space" it should create an exact replica of the wiki space at that point in time (when the button was clicked). Cause If I start deleting/adding stuff post that clone button hit, and my job starts after that, I get a replica of the current state of my wiki space rather than the original state.

probably all the space items would need to be sent to the clone job?

phot0n commented 4 months ago

also this: https://github.com/frappe/wiki/blob/2b2689894e5c3148dbd7f05b37846a3f3c6f9bb6/wiki/wiki/doctype/wiki_page/wiki_page.py#L355

should ideally be .replace(x, y, 1)