search

frappe / wiki

Free and Open Source Wiki built on top of Frappe
https://frappe.io/wiki
MIT License
219 stars 168 forks source link

fix: prevent private pages from showing in sidebar #243

Closed mgiadach closed 2 months ago

mgiadach commented 2 months ago

Wiki Pages have an "Allow Guest" option that, when unchecked, prevents the page from being read from unauthorized users (either non logged-in users or logged-in users without the read permission on the Wiki Page doctype). While this works, if the page belongs to a Sidebar, the page title and link are shown regardless of the "Allow guest" option.

This PR fixes that issue, ensuring that private pages are not displayed in the Sidebar.

Screencast from 2024-05-29 16-01-42.webm

Related issue: #221

cypress[bot] commented 2 months ago

Passing run #312 ↗︎

0 5 0 0 Flakiness 0

Details:

Merge 99d73c5757554eb8c36200bc3c26faeb0609b545 into 0d3aafe641cf1da79809782c1c00...
Project: Wiki Commit: 515ac1f190 ℹ️
Status: Passed Duration: 00:18 💡
Started: May 30, 2024 2:01 PM Ended: May 30, 2024 2:01 PM

Review all test suite changes for PR #243 ↗︎

mgiadach commented 2 months ago

Hi @rmehta, thanks for your review! Could we merge this, please?