frappe / wiki

Free and Open Source Wiki built on top of Frappe
https://frappe.io/wiki
MIT License
219 stars 168 forks source link

New pages are not added to sidebar after patch approval #244

Closed mgiadach closed 2 months ago

mgiadach commented 2 months ago

Description

When a user who does not have the Wiki Approver role creates a new wiki page from the sidebar, a new Wiki Page Patch is created. After the patch is approved, the page is indeed published, but it is not added to the sidebar.

Steps to reproduce

  1. Log in as a user without the Wiki Approver role and click on "Edit Sidebar." Then, click on the "+" icon next to any group to create a new page.
  2. Fill in the page content and click "Save".
  3. Log in as a user with the Wiki Approver role, navigate to the Desk, and locate the newly created Wiki Page Patch.
  4. Set the status to Approved, fill in the Approved By field, save, and submit the document.

Expected behavior

The new wiki page should be published and added to the sidebar group where it was created.

Actual behavior

The new wiki page is published, but is not added to any sidebar group.

Tested on

Frappe Framework: v15.27.0 (version-15) Wiki: v2.0.0

Evidence

Screencast from 2024-05-29 17-54-42.webm