Adding advanced networking, additional hardware, and more

[mahcsig]

Added several features here:

• Attribute to specify vApp name
• Advanced networking
  • Add Org VDC networks to vApp
  • Add vApp networks to vApp
• Add vApp metadata
• Add VM metadata
• Guest customization rolled up into compose/recompose to avoid additional call
• Moved set_hardware to build_vapp from power_on, it seemed to make more sense there
• Add hard disks
• Update / add network cards and configuration
• Added switches for power_on, ssh, file syncing, and auto uploading boxes to vCloud

[frapposelli]

Thanks! this is massive! I'm swamped these weeks but will review/merge asap.

[StefanScherer]

@marc-ta my intention to add the set_hardware in power_on was to enable the user to make little changes to cpus and memory with just a vi Vagrantfile && vagrant reload as this is also possible with the vmware_fusion and virtualbox provider.

Your PR sounds very, very interesting. I'll have a look at it, too.

[tsugliani]

Nice list of changes, will take a look too :)

Thanks @marc-ta

[mahcsig]

@StefanScherer That makes sense, hadn't thought of it that way. It's pretty well contained, so it wouldn't be to hard to move it back.

[StefanScherer]

@marc-ta thanks for moving set_vm_hardware back to power_on. I've merged your PR into my personal branch and played a little with your improvements. The vapp_name and add_hdds features are very useful for me!

For a Windows box I managed to use the additional HDD as drive D with this powershell script:

Write-Host "Adding second disk D"

$addDriveD = @'
select disk 1
attributes disk clear readonly
online disk
create partition primary
format quick
assign letter D
'@

$addDriveD | Out-File $env:TEMP\addDriveD.txt -Encoding ascii
& diskpart /s $env:TEMP\addDriveD.txt

With this I don't have to create multiple VM templates with different disk sizes. Thanks a lot!

[StefanScherer]

@marc-ta thanks again for the add_hdds feature. I've just cleaned up my basebox-slave installation with this commit to use default sized base boxes (Windows) for the Jenkins slaves and adding a second disk and mount it as my Jenkins work directory.

I'm currently running a pre-release of vagrant-vcloud with your PR and some of mine. BTW: The vagrant-serverspec plugin is going to Serverspec V2, I've started to use it to test my base boxes.

[StefanScherer]

@marc-ta Seems that needs a rebase.

[StefanScherer]

@frapposelli What about merging this after a rebase? This is a major enhancement for the vagrant-vcloud plugin. A colleage just asked me for the change SID feature.

[frapposelli]

Sure, it's definitely ripe for merge, thanks for doing CR on this @StefanScherer

Once the rebase and the fixes are done I'll merge on dev.

[StefanScherer]

One change is missing, but I have sent a PR to fix this PR in the forked repo.

[mahcsig]

@StefanScherer, @frapposelli I have rebased, added the pull request, and added a few fixes that I found I hadn't pushed up.

[frapposelli]

@marc-ta looks good, can you please squash the commits and force push?

@StefanScherer did you test it? everything looks good on your side?

[StefanScherer]

@frapposelli I tried a small test from a clean Windows box. But I've installed Vagrant 1.8.1 and now I get an error. I've opened #122 to have a closer look at that. Now setting up another test env with Vagrant 1.7.4 and have a test drive...

[StefanScherer]

@frapposelli Down to Vagrant 1.7.4 I have tested the gem with the latest commits of this PR. It creates the edge gateway rules. LGTM.

[frapposelli]

LGTM

[frapposelli]

whops, just realized this was sent against master, can you please resend this against develop ?

[mahcsig]

moving to dev branch

[mahcsig]

New PR #123 added.