frasermclean / adoptrix

Pet adoption centre platform
https://demo.adoptrix.com
MIT License
1 stars 0 forks source link

Refactor to pure Minimal API #42

Closed frasermclean closed 8 months ago

frasermclean commented 8 months ago

Remove all uses of Fast Endpoints

github-actions[bot] commented 8 months ago

Solution test results

58 tests  +26   57 :white_check_mark: +26   18s :stopwatch: +10s  5 suites ± 0    1 :zzz: ± 0   5 files   ± 0    0 :x: ± 0 

Results for commit 36261d9a. ± Comparison against base commit f3a8536b.

This pull request removes 3 and adds 29 tests. Note that renamed tests count towards both. ``` Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: "Max", description: "", speciesName: "unknown", breedName: "Eastern Gray", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: "Rufus", description: "Another good boy", speciesName: "dog", breedName: "unknown", sex: null, ageInYears: 0) Adoptrix.Jobs.Tests.Functions.AnimalDeletedImageCleanupTests ‑ Run_WithValidData_Should_Pass(imageCount: 28, animalId: 88ef99e2-5240-4890-a329-98613eb606ea) ``` ``` Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimalImages_WithValidCommand_Should_Return_Ok(fileName: "lab_puppy_1.jpeg") Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: "Max", description: "", speciesName: "unknown-species", breedName: "Eastern Gray", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: "Rufus", description: "Another good boy", speciesName: "dog", breedName: "unknown-breed", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ UpdateAnimal_WithValidRequest_Should_Return_Ok Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ AddBreed_WithDuplicateBreedName_Returns_BadRequest Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ AddBreed_WithValidRequest_Returns_Created Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ DeleteBreed_WithUnknownBreedId_Returns_NotFound Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ DeleteBreed_WithValidBreedId_Returns_NoContent Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ GetBreed_WithUnknownBreedIdOrName_Returns_NotFound(breedIdOrName: "00000000-0000-0000-0000-000000000000") Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ GetBreed_WithUnknownBreedIdOrName_Returns_NotFound(breedIdOrName: "unknown-breed") … ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (f3a8536) 46.15% compared to head (36261d9) 64.37%.

Files Patch % Lines
...x.Api/Endpoints/Animals/AddAnimalImagesEndpoint.cs 57.40% 19 Missing and 4 partials :warning:
...ructure/Services/Repositories/AnimalsRepository.cs 0.00% 12 Missing :warning:
...trix.Api/Endpoints/Animals/UpdateAnimalEndpoint.cs 60.00% 6 Missing and 4 partials :warning:
...tructure/Services/Repositories/BreedsRepository.cs 0.00% 9 Missing :warning:
...ructure/Services/Repositories/SpeciesRepository.cs 0.00% 8 Missing :warning:
...ptrix.Api/Endpoints/Breeds/SearchBreedsEndpoint.cs 75.00% 0 Missing and 2 partials :warning:
...doptrix.Api/Endpoints/Animals/AddAnimalEndpoint.cs 96.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #42 +/- ## =========================================== + Coverage 46.15% 64.37% +18.22% =========================================== Files 90 70 -20 Lines 884 845 -39 Branches 54 58 +4 =========================================== + Hits 408 544 +136 + Misses 464 285 -179 - Partials 12 16 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.