frasermclean / adoptrix

Pet adoption centre platform
https://demo.adoptrix.com
MIT License
1 stars 0 forks source link

Make use of problem details service #47

Closed frasermclean closed 7 months ago

github-actions[bot] commented 7 months ago

Solution test results

63 tests  +4   62 :white_check_mark: +4   19s :stopwatch: -1s  5 suites ±0    1 :zzz: ±0   5 files   ±0    0 :x: ±0 

Results for commit 463f9184. ± Comparison against base commit d9b488d2.

This pull request removes 8 and adds 12 tests. Note that renamed tests count towards both. ``` Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimalImages_WithValidCommand_Should_Return_Ok(fileName: "lab_puppy_1.jpeg") Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: "Max", description: "", speciesName: "unknown-species", breedName: "Eastern Gray", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: "Rufus", description: "Another good boy", speciesName: "dog", breedName: "unknown-breed", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidCommand_Should_Return_BadRequest(name: null, description: null, speciesName: null, breedName: null, sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithValidCommand_Should_Return_Ok Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ AddBreed_WithDuplicateBreedName_Returns_BadRequest Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ UpdateBreed_WithDuplicateBreedName_Returns_BadRequest Adoptrix.Jobs.Tests.Functions.AnimalDeletedImageCleanupTests ‑ Run_WithValidData_Should_Pass(imageCount: 167, animalId: a5d56728-5d5d-47b3-b6b4-ff5456c8c1c2) ``` ``` Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimalImages_WithInvalidContent_Should_Return_ProblemDetails Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimalImages_WithUnknownAnimalId_Should_Return_NotFound Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimalImages_WithValidCommand_Should_Return_Ok Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidRequest_Should_Return_ProblemDetails(name: "Max", description: "", speciesName: "unknown-species", breedName: "Eastern Gray", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidRequest_Should_Return_ProblemDetails(name: "Rufus", description: "Another good boy", speciesName: "dog", breedName: "unknown-breed", sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithInvalidRequest_Should_Return_ProblemDetails(name: null, description: null, speciesName: null, breedName: null, sex: null, ageInYears: 0) Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ AddAnimal_WithValidRequest_Should_Return_Ok Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ UpdateAnimal_WithInvalidRequest_Should_Return_ProblemDetails Adoptrix.Api.Tests.Endpoints.AnimalEndpointTests ‑ UpdateAnimal_WithUnknownAnimalId_Should_Return_NotFound Adoptrix.Api.Tests.Endpoints.BreedEndpointTests ‑ AddBreed_WithDuplicateBreedName_Returns_ProblemDetails … ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.29%. Comparing base (d9b488d) to head (463f918).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ========================================== + Coverage 65.12% 68.29% +3.17% ========================================== Files 72 68 -4 Lines 863 839 -24 Branches 60 43 -17 ========================================== + Hits 562 573 +11 + Misses 285 257 -28 + Partials 16 9 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.