search

frasertweedale / hs-jose

Haskell JOSE and JWT library
http://hackage.haskell.org/package/jose
Apache License 2.0
122 stars 46 forks source link

Expose Crypto.JOSE.JWA.JWK #1

Closed carlohamalainen closed 10 years ago

carlohamalainen commented 10 years ago

For my AAF JWT project I needed something from JOSE.JWA.JWK.

frasertweedale commented 10 years ago

Hai Carlo,

I think I'd prefer to leave Crypto.JOSE.JWA.JWK internal and export these constructors via Crypto.JOSE.JWA instead. I'll try and get to that on the weekend... can't promise that though :)

Thanks for using my library - it has been delightful discovering the use cases I hadn't considered and related library usability issues.

carlohamalainen commented 10 years ago

I think I'd prefer to leave Crypto.JOSE.JWA.JWK internal and export these constructors via Crypto.JOSE.JWA instead.

That sounds good.

Thanks for using my library - it has been delightful discovering the use cases I hadn't considered and related library usability issues.

Happy to help. Also I'm now of the opinion that the two projects should be merged. The JWT stuff isn't really usable without things from hs-jose so they may as well live togther.

frasertweedale commented 10 years ago

On Thu, Aug 07, 2014 at 09:18:24PM -0700, Carlo Hamalainen wrote:

I think I'd prefer to leave Crypto.JOSE.JWA.JWK internal and export these constructors via Crypto.JOSE.JWA instead.

That sounds good.

Thanks for using my library - it has been delightful discovering the use cases I hadn't considered and related library usability issues.

Happy to help. Also I'm now of the opinion that the two projects should be merged. The JWT stuff isn't really usable without things from hs-jose so they may as well live togther.

I have been in contact with the developer of Web.JWT, who was keen to merge/refactor provided I move hs-jose to a permissive free software license. I did that (switched to Apache 2.0) and informed the other party, so ball's in their court.

BTW, hs-jwt is currently GPL3. Hope that's not a problem for you (though if I do end up merging it into JOSE, I will relicense to Apache 2.0).

Cheers,

Fraser

Reply to this email directly or view it on GitHub: https://github.com/frasertweedale/hs-jose/pull/1#issuecomment-51561840

frasertweedale commented 10 years ago

my proposed changes (both the import issue and the "construct a minimal key" proposal are now in hs-jose commit 7c3c5f5 ; I've created a PR for your demo app with the minor changes needed to update to the new API.