search

frasertweedale / hs-jose

Haskell JOSE and JWT library
http://hackage.haskell.org/package/jose
Apache License 2.0
122 stars 46 forks source link

kty parameter missing in FromJSON/ ToJSON instances #113

Closed marijanp closed 1 year ago

marijanp commented 1 year ago

According to https://www.rfc-editor.org/rfc/rfc7517#section-4.1 this is a mandatory parameter

frasertweedale commented 1 year ago

@marijanp can you please elaborate? You closed the issue already - was it a mistake?

marijanp commented 1 year ago

It was a mistake, I overlooked the code which called the KeyMaterial instance. Whoever might be interested here is the instance implementation https://hackage.haskell.org/package/jose-0.10/docs/src/Crypto.JOSE.JWA.JWK.html#line-558

frasertweedale commented 1 year ago

@marijanp thank you for the clarification.