search

frasertweedale / hs-jose

Haskell JOSE and JWT library
http://hackage.haskell.org/package/jose
Apache License 2.0
122 stars 46 forks source link

Use crypton instead of cryptonite #115

Closed kokobd closed 8 months ago

kokobd commented 1 year ago

Resolves #114.

Bumped the major version as cryptonite was used in public API, at least MonadRandom in Crypto.JWT.signJWT

frasertweedale commented 1 year ago

Thanks for the PR. There are some major API-breaking changes I want to make at the same time as the switch to crypton. So I will deal with it later. Are you critically blocked by the lack of crypton support in jose at this time?

kokobd commented 1 year ago

Are you critically blocked by the lack of crypton support in jose at this time?

No, I'm not in hurry. I'm in the process of removing cryptonite transitively in my project, and discovered this along the way. So using it in source-repository-package is enough for my purpose.

larskuhtz commented 8 months ago

It would be nice to support crypton before making breaking API changes.

That would enable the use of crypton without the immediate need to integrate the new API. (Note that the switch to crypton doesn't include any API change.)

At this point many projects on Hackage switched to crypton and additionally using cryptonite becomes a bit of a legacy.

frasertweedale commented 8 months ago

It would be nice to support crypton before making breaking API changes.

That would enable the use of crypton without the immediate need to integrate the new API. (Note that the switch to crypton doesn't include any API change.)

At this point many projects on Hackage switched to crypton and additionally using cryptonite becomes a bit of a legacy.

I agree and I will support crypton in the current series, through a cabal flag.

frasertweedale commented 8 months ago

Released https://hackage.haskell.org/package/jose-0.11. Thanks for your efforts and patience.