search

frasertweedale / hs-jose

Haskell JOSE and JWT library
http://hackage.haskell.org/package/jose
Apache License 2.0
122 stars 46 forks source link

use crypton instead #119

Closed silky closed 8 months ago

silky commented 8 months ago

Basically the exact same PR as this one - https://github.com/frasertweedale/hs-jose/pull/115/files - but bumps the required version of crypton because it is available now!

Just curious to see if this will pass all the builds.

silky commented 8 months ago

Fixes https://github.com/frasertweedale/hs-jose/issues/114.

FWIW I want this because I get an error in some code like:

    • Couldn't match expected type ‘cryptonite-0.30:Crypto.PubKey.RSA.Types.PrivateKey’
                  with actual type ‘Crypto.PubKey.RSA.Types.PrivateKey’

because I'm on one side using crypton's version of x509, and on the other use jose's version (cryptonite).

silky commented 8 months ago

FWIW the builds fail on ghc 8.6.5 or lower because crypton just doesn't build there, it seems.

I'm not sure what it means for merging this PR, or how fixable it is.

frasertweedale commented 8 months ago

Thanks @silky, I will review and solve this problem soon. Originally I thought I would use cabal flags but I think it's better to just do a hard cutover, and maintain the v0.10 in a "bug fixes only" mode for some time. This approach will simplify the testing, that's for sure.

frasertweedale commented 8 months ago

Released https://hackage.haskell.org/package/jose-0.11. Thanks for your efforts and patience.