search

frasertweedale / hs-jose

Haskell JOSE and JWT library
http://hackage.haskell.org/package/jose
Apache License 2.0
122 stars 46 forks source link

broken with GHC-8.2 #51

Closed phadej closed 7 years ago

phadej commented 7 years ago

See https://matrix.hackage.haskell.org/package/jose

Upper-boundless dependency on template-haskell is a bad idea. IIRC it breaks with each major version.

This is impediment for making servant-auth GHC-8.2 ready.

phadej commented 7 years ago

You can test GHC-8.2-rc3 with stack:

frasertweedale commented 7 years ago

We already had the fix in master. Have cherry-picked the fix to maint/0.6 and cut release v0.6.0.3.

Will add upper bound on template-haskell dep soon.

Thanks!

phadej commented 7 years ago

@frasertweedale could you make revisions for old jose releases, (the matrix shows what's broken). I tripped on this, as solver happily picks 0.5.x versions (when packages have jose <0.6 bound) when used with GHC-8.2

frasertweedale commented 7 years ago

On Mon, Jul 17, 2017 at 01:03:02PM +0000, Oleg Grenrus wrote:

@frasertweedale could you make revisions for old jose releases, (the matrix shows what's broken). I tripped on this, as solver happily picks 0.5.x versions (when packages have jose <0.6 bound) when used with GHC-8.2

Sure, will get onto this in next day or so.

Cheers, Fraser

frasertweedale commented 7 years ago

@phadej http://hackage.haskell.org/package/jose-0.5.0.5 <- there ya go!