search

frasertweedale / hs-jose

Haskell JOSE and JWT library
http://hackage.haskell.org/package/jose
Apache License 2.0
122 stars 46 forks source link

Add support for EC JWKs #93

Closed jaspervdj closed 4 years ago

jaspervdj commented 4 years ago

This adds support for constructing JWKs from X509 EC certificates.

Feel free to tear this PR apart, and let me know what you need to get this merged. I'm happy to make changes to naming, structure and add tests.

frasertweedale commented 4 years ago

@jaspervdj it looks fine to me. A test would be nice. Hypocritical of me to ask because it seems I don't have any existing test for X.509-to-JWK behaviour. But, since you offered... :)

frasertweedale commented 4 years ago

Thank you very much @jaspervdj. I'll cut a new release in the next day or so.

jaspervdj commented 4 years ago

@frasertweedale Oh! I actually still had a test coming up. I'll open a separate PR.

frasertweedale commented 4 years ago

@jaspervdj v0.8.3 released: https://hackage.haskell.org/package/jose-0.8.3

Many thanks for your contribution.

P.S. Thanks for hakyll :)