fraserw / trippy

Python based Trailed Source Photometry
GNU General Public License v3.0
20 stars 13 forks source link

Reuse "saved" background, or similar #34

Closed Mikea1985 closed 4 years ago

Mikea1985 commented 4 years ago

I just had a conversation with Rosemary, and wanted to write down the gist of it, more as a reminder for future development than as an immediate issue requiring attention.

Basically, it boils down "make life easier for when you have to re-process your data several times", which of course means removing any steps where a human has to interfere/click on something. Currently a PSF model can be loaded from a saved file, which allows the user to skip the biggest human-interactionstep (the psfStarChooser step) during reprocessing (assuming PSF model is trusted). However, unless one is happy with either the full background box or the automatic trimming (using trimBGHighPix), there is no way to skip the background inspection/selection step of the pill.pillPhot call.

We proposed two solutions (requiring different ammounts of effort to implement):

One or both of these would make it a lot faster to quickly re-process data automatically in-full without any human intervention.

fraserw commented 4 years ago

Both of these things are essentially already implemented.

option one can be had with display=False and enableBGselection=False. Trimming high pixels can occur with or without the display.

The second option is the zoomRegion option. This has been documented in the pillPhot.call function for a while, but not shown in the tutorial for clarity. So it isn't surprising you missed it. if zoomRegion is provided a float 4-tuple, it will automatically set to that region. display=True and enableBGselection = True for this to work.

Accessing the selected region once photometry has been done is though the pillPhot.beSelectionRegion variable. This was accidentally ommitted from the function documentation.

I have updated the function call doc string to inform the bgSelectionRegion bit.