search

fraserxu / electron-pdf

📄 A command line tool to generate PDF from URL, HTML or Markdown files.
MIT License
1.24k stars 136 forks source link

Fixed multiple issues with regard to capturing file downloads #252

Closed codecounselor closed 5 years ago

codecounselor commented 5 years ago
  1. window event listeners should use once instead of on
  2. Corrected the arguments bound to generateFunction (missed from last change)
  3. If noprint is specified, waiting should be disabled (both readyEvent and wait). The client is expected to block and initiate the file download when appropriate.
mattsgarlata commented 5 years ago

+1, but looks like the CI build failed

codecounselor commented 5 years ago

Yeah I saw that, all the tests pass. Travis must be slow or something, I'll bump up the timeout threshold for the tests and see if that resolves it.

codecounselor commented 5 years ago

I'll look into this test failure later, it's something with the travisCI environment, merging