fraserxu / electron-pdf

📄 A command line tool to generate PDF from URL, HTML or Markdown files.
MIT License
1.24k stars 136 forks source link

Generated PDF does not preserve tab order in tables, with or without tabindex #306

Open tzbarkan opened 2 years ago

tzbarkan commented 2 years ago

Using v1.1.7 on Windows 10.

With a plain table in a validated HTML file, the tab order isn't preserved.

<table>
    <tr>
        <td><a href="#">Link A</a></td>
        <td>Some text</td>
        <td><textarea name="Text A"></textarea></td>
    </tr>
    <tr>
        <td><a href="#">Link B</a></td>
        <td>Some text</td>
        <td><textarea name="Text B"></textarea></td>
    </tr>
</table>

Expected result: the tab order should be:

  1. Link A
  2. Text A
  3. Link B
  4. Text B

Actual result: the tab order is:

  1. Link A
  2. Link B
  3. Text A
  4. Text B

So I added tabindex to all of my links and fields.

<table>
    <tr>
        <td><a tabindex="1" href="#">Link A</a></td>
        <td>Some text</td>
        <td><textarea tabindex="2" name="Text A"></textarea></td>
    </tr>
    <tr>
        <td><a tabindex="3" href="#">Link B</a></td>
        <td>Some text</td>
        <td><textarea tabindex="4" name="Text B"></textarea></td>
    </tr>
</table>

No change in tab order