search

fraserxu / electron-pdf

📄 A command line tool to generate PDF from URL, HTML or Markdown files.
MIT License
1.24k stars 136 forks source link

upgrade electron dependence #320

Closed SnowRunescape closed 1 year ago

SnowRunescape commented 1 year ago

upgrade dependence electron

mattsgarlata commented 1 year ago

@jerryorr would you please review this?

SnowRunescape commented 1 year ago

@jerryorr, thank you for the speed of approval, I am very happy.

Can you create a version in npm? we need to fix a problem

mattsgarlata commented 1 year ago

@jerryorr I think there were several other things that needed to go into this change as well, based on the last time you bumped the electron version: https://github.com/fraserxu/electron-pdf/commit/b03284fd8d273094a91de3931be47605ed644224

SnowRunescape commented 1 year ago

@mattsgarlata @jerryorr https://github.com/fraserxu/electron-pdf/pull/321 I made the necessary changes

jerryorr commented 1 year ago

@SnowRunescape new verison is on npm https://www.npmjs.com/package/electron-pdf