search

fraserxu / electron-pdf

📄 A command line tool to generate PDF from URL, HTML or Markdown files.
MIT License
1.24k stars 136 forks source link

cli.js problem no-sandbox #324

Closed brunoCaitano-estuda closed 1 year ago

brunoCaitano-estuda commented 1 year ago

why does this code exist? it prevents the execution of the --no-sandbox parameter

image

I'm having trouble mounting a docker image with the same image

brunoCaitano-estuda commented 1 year ago

reading the PR, it seems to be a problem that happens in windows. https://github.com/fraserxu/electron-pdf/pull/248

Do you think it's valid to implement an if? @mattsgarlata @jerryorr

if (process.platform !== 'linux') {
  args.unshift('--')
}
jerryorr commented 1 year ago

Seems reasonable, though if that's only needed for Windows, I'd do == 'windows' (or whatever) instead, so that the behavior doesn't change for macOS.

brunoCaitano-estuda commented 1 year ago

Perfect, I'll run a test on macOS and return feedback by opening a PR

aroldoGoulart-estuda commented 1 year ago

Perfect, I'll run a test on macOS and return feedback by opening a PR

Ill run the test here @jerryorr

brunoCaitano-estuda commented 1 year ago

that was not the problem