fratsloos / fr24_card

Lovelace card for showing Dump1090 data from FR24 in Home Assistant
42 stars 5 forks source link

v1.0.0-alpha Built-in Pop-up missing Close button #27

Closed BrettEBowman closed 10 months ago

BrettEBowman commented 10 months ago

I just installed the new 1.0.0-alpha version. It is a nice improvement!

One bug/problem that I noticed is when I use the built-in pop-up window, I'm not seeing a "X" button to close it. Maybe it is something with my card_mod setup???

Here's my card config:

type: custom:fr24-card
entity: sensor.msp_piaware_flights
providers:
  adsbexchange: false
  flightaware: true
  flightradar24: true
  opensky_network: true
  plane_finder: false
columns:
  - flag
  - registration
  - flight
  - icon
  - altitude
  - speed
  - distance
hide:
  empty:
    - distance
    - altitude
  ground_vehicles: true
popup: true
zone: zone.home
sort: distance
fratsloos commented 10 months ago

Thanks for the feedback. I'll have a look at it! 👍

fratsloos commented 10 months ago

The button is not visible because of the config I'm using in browser_mod. I'm hiding the complete header, because it takes a lot of space on smaller screens and it is not really useful. Closing the card is possible by clicking outside of it and the title is below the image.

In the related branch I've changed the config for popup to an object. In this object it is now possible to enable the popup and enable the header of the popup.

I have a few more issues I want to update for a new pre-release. When the pre-release is available you can update it again in HACS.

fratsloos commented 10 months ago

I've just released the new pre-release with an updated config for the popup. With the new config you can enable the header. This fixes this issue.

BrettEBowman commented 10 months ago

I can confirm that with the new beta version, I could enable the header (and get the close button).

Note: I had to force a "clear cache and hard reset" in Chrome as reference in this comment.

fratsloos commented 10 months ago

Thanks for the update. I was kind of hoping the reload by HACS was enough: on my instance it always gives a warning to reload the browser.