fratzinger / feathers-casl

feathers.js + casl: hooks & channels
https://feathers-casl.netlify.app/
MIT License
40 stars 18 forks source link

highlight changes required for dove #67

Closed marshallswain closed 1 year ago

marshallswain commented 2 years ago

There are still 3 or 4 broken tests in this PR.

marshallswain commented 2 years ago

image

@fratzinger, why should the first .find in the above screenshot fail with the given message? It seems like that query should work and return an empty array result. Please enlighten me.

marshallswain commented 2 years ago

I was able to make the authorize hook work as an around, before, after hook. An around hook is not technically supposed to return context, but I did it anyway to make the types simpler. It doesn't break anything if you return context after calling await next().

Screen Shot 2022-08-28 at 5 12 07 PM .

marshallswain commented 2 years ago

I've used all of the time I have available to work on this PR, so feel free to grab what you want and close.

fratzinger commented 1 year ago

Hey marshall, thanks for the PR! This marks a milestone for me, because it's the first time you've contributed to one of my repos and not the other way around 😅🎉

Thanks to your work, I continued my work in the dove branch: https://github.com/fratzinger/feathers-casl/tree/dove And finally released a pre version as feathers-casl@pre. It got a few new things:

Things I have to do in future pre releases:

Thanks again for the work, you have put into this! I close this PR, because I think I got all covered in the dove branch now.