search

fraunhoferhhi / vvdec

VVdeC, the Fraunhofer Versatile Video Decoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
428 stars 85 forks source link

docs: stride is in bytes, not in samples #145

Closed cadubentzen closed 1 year ago

cadubentzen commented 1 year ago

The comment for the stride in vvdecPlane states that it's in number of samples, but in reality it's in number of bytes, as seen in

https://github.com/fraunhoferhhi/vvdec/blob/3c43ba15b92abde704bb1b43d9bf38560ebf78b0/source/Lib/vvdec/vvdecimpl.cpp#L1203-L1205

adamjw24 commented 1 year ago

Hi Carlos, good catch!

Since this is only a minor comment change, even tho very important one, I think it does not necessitate an authors.md entry. Especially since additional authors have implications for project steering.

If that'd be alright with you, could you adapt the PR? I'll try to adapt our readme.md to be more clear in that point.

cadubentzen commented 1 year ago

If that'd be alright with you, could you adapt the PR? I'll try to adapt our readme.md to be more clear in that point.

Hi @adamjw24 no worries at all :) Yes I mainly just followed the README instructions, so the extra clarity would be welcome.