search

fraunhoferhhi / vvdec

VVdeC, the Fraunhofer Versatile Video Decoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
454 stars 91 forks source link

Fix crash in MSVC Debug build when use SSE 4.1 due uninitialized variables. #176

Closed Aleksoid1978 closed 4 months ago

Aleksoid1978 commented 4 months ago

Shouldn't we always initialize __m256i and __m128i variables, and not just in Debug mode? There, in the code, reading from an uninitialized variable occurs.

Using an uninitialized variable - this is a potential UB.

adamjw24 commented 4 months ago

If you look into the code, you can see all the variables are initialized properly, no UB will happen. At least not with the block sizes possible in VVC. For Debug Mode I know MSVC is oversensitive sometimes.