search

fraunhoferhhi / vvdec

VVdeC, the Fraunhofer Versatile Video Decoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
454 stars 91 forks source link

v1.0.0.0 decode POUT_A_Sharplabs_2.bit failed #40

Closed chenm001 closed 3 years ago

chenm001 commented 3 years ago

I report this issue in discussions page, and I just confirm it is a bug this morning.

In the latest v1.0.0.0 code, we will get decoded output YUV hash check failed on sequence POUT_A_Sharplabs_2.bit. The root cause is the sequence POUT_A_Sharplabs_2.bit active ph_pic_output_flag for bypass some of output frames. However, in the source code, the below code was disabled for unknown reasons since v1.0.0.0 release. pcPic->neededForOutput = (pcSlice->getPicHeader()->getPicOutputFlag() ? true : false);

adamjw24 commented 3 years ago

Thanks for finding the issue. There were some problems with the derivation of the flag regarding tuning in and GDR. We plan on doing the cleanup of the management of this flag soon, hopefully it will resolve the issue.

adamjw24 commented 3 years ago

fixed in #49