Closed ChristianFeldmann closed 3 years ago
Hi Christian, Thank you very much for your contribution.
Unfortunately, there are two separate issues concerning this PR:
We would like to keep the lib/bin
separation in the build tree. I think this is not a quirk by CMake, but it just adheres to the platform conventions. On *nix-systems you typically install the binaries in /usr/{local/}bin/
and libraries in /usr/{local/}lib/
, while on Windows programs typically put their libraries next to the executable. I think it would lead to more confusion, if the build step puts the shared libraries into the bin
folder during build, but during install they end up in lib
.
We have not come to a final decision if we are going to provide official binaries for VVdeC.
So, I would like to put your PR on hold for now, until we have decided on the binaries issue, but feel free to provide the binaries from your repository.
Got it. Just wanted to show how this stuff works. Then I will use it in my fork for the releases.
There are 3 changes in this that I would like to propose:
dll
file would go into thebin
output folder while on linux/mac the.so
and.dylib
file would go into thelib
folder. This is a Cmake quirk where dll and so/dylib are handled differently (see https://stackoverflow.com/questions/56514533/how-to-specify-the-output-directory-of-a-given-dll). I think this should be consistent and all of them should go into the runtime folder (bin
). This also helps with point 2:bin
) to the build as an artifact. Then for each build you can just download the compiled files and ... well do whatever you want with them. I also enabled building of static and non static on most platforms. For the ubuntu 16 and 18 this could also be enabled.