search

fraunhoferhhi / vvdec

VVdeC, the Fraunhofer Versatile Video Decoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
465 stars 97 forks source link

STDOUT on Windows not functioning #51

Closed baxxtor closed 3 years ago

baxxtor commented 3 years ago

Stdout on Windows is not functioning. Although stdout ir outputting data, the data is is in some format that the video is not useable. However, STDOUT data on Centos appears to working as expected.

1480c1 commented 3 years ago

to the developers, it might be worth it to look into https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode?view=msvc-160 and seeing if you need to set O_BINARY on the stdout, same with stdin for vvencc

baxxtor commented 3 years ago

You may have a point. Perhaps Windows by default is outputting stdin / stdout as text instead of binary.

On Wed, Apr 14, 2021 at 6:58 PM Christopher Degawa @.***> wrote:

to the developers, it might be worth it to look into https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode?view=msvc-160 and seeing if you need to set O_BINARY on the stdout, same with stdin for vvencc

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fraunhoferhhi/vvdec/issues/51#issuecomment-819902068, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKVVZWJMWFDQOVOIKPX4CLTIYMYLANCNFSM426JKQYA .

baxxtor commented 3 years ago

Developers, this article may also be of interest to you: https://docs.microsoft.com/en-us/cpp/c-runtime-library/text-and-binary-mode-file-i-o?view=msvc-160

On Wed, Apr 14, 2021 at 6:58 PM Christopher Degawa @.***> wrote:

to the developers, it might be worth it to look into https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setmode?view=msvc-160 and seeing if you need to set O_BINARY on the stdout, same with stdin for vvencc

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fraunhoferhhi/vvdec/issues/51#issuecomment-819902068, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKVVZWJMWFDQOVOIKPX4CLTIYMYLANCNFSM426JKQYA .

baxxtor commented 3 years ago

I can confirm the stdout fix is working on Windows. Thank You.

adamjw24 commented 3 years ago

Seems fixed for Windows. Problems reported under PowerShell, but works with cmd.exe.