search

fraunhoferhhi / vvdec

VVdeC, the Fraunhofer Versatile Video Decoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
465 stars 97 forks source link

1. Optimize decodeBin and decodeBinsEP; 2. Optimize Intra pixel fill… #71

Closed xrayleigh2000 closed 2 years ago

xrayleigh2000 commented 2 years ago

Modify point： 1.Optimize decodeBin and decodeBinsEP; 2.Optimize Intra pixel filling; 3.Optimize the SAD calculation in MDVR(5 SAD calculations at the same time to save the number of times to read data); 4.Combine BioGradFilter and pad;

Test: 1.The conformance test is performed using the command line “make test-all”, and all tests pass; 2.Tested the decoding time of single thread and multi thread. For the 0/2/10/20 thread configuration, the average decoding time is 98.06%/97.03%/97.52%/97.66% as before;

K-os commented 2 years ago

Hi xrayleigh2000, Thank you very much for the pull request. We will look into it and give you feedback.

I only took a really short look at it, but I have one remark for you for next time: When you make multiple completely unrelated changes (e.g. the CABAC stuff and the intra prediction), can you please split it in separate commits next time. That makes reviewing the changes much easier.

xrayleigh2000 commented 2 years ago

Hi K-os, I divided the commit into four, the code is the same as the previous commit.

K-os commented 2 years ago

Oh, thank you very much.

adamjw24 commented 2 years ago

Just tested the changes. It does improve the runtimes a bit. Nice, thanks. Will be merged soon.

adamjw24 commented 2 years ago

Just one last thing. This is a major change with in-depth knowledge and proper impact. Feel free to add yourself to the contributors list (AUTHORS.txt) in the PR.

xrayleigh2000 commented 2 years ago

I have added my name to AUTHORS.md