Closed xrayleigh2000 closed 2 years ago
Nice work. Looks good to me for the most part.
A few comments:
CtuAlfData
into CtuData
and remove Picture::m_ctuAlfData
? The structure is memset to '0' at the beginning of slice parsing (CodingStructure::initStructData
), so no need to have a constructor. All of the resize logic can be removed too.readAlfCtuFilterIndex2
back to readAlfCtuFilterIndex
. Or is there a reasoning behind the name change?Hi, adamjw24: I merged your pull request into my branch, which caused the commit to be a bit messy. Did I need to sort out and merge the commit record?
In addition, the optimization of loopfilter is as follows:
It would be great if you could cleanup the commits a bit.
I'll clean up the commits and submit them later
Good stuff. The LoopFilter really has an impact. Thanks. Merging.
Modify point: 1.Optimize the calculation of the filter parameters of the deblock 2.The parameters of ALF are changed from struct of array to array of struct to improve data access 3.CC-ALF of the two chroma components is performed simultaneously (if possible), so that the calculation results of luma can be reused
Test: 1.The conformance test is performed using the command line “make test-all”, and all tests pass; 2.Tested the decoding time of single thread and multi thread. For the 0/2/10/20 thread configuration, the average decoding time is 97.86%/97.37%/98.85%/99.23% as before;