fraunhoferhhi / vvenc

VVenC, the Fraunhofer Versatile Video Encoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
943 stars 170 forks source link

VVC not building with media-autobuild_suite? #324

Closed JohnTravolski closed 10 months ago

JohnTravolski commented 11 months ago

I tried to create an ffmpeg build with VVC for Windows following instructions referencing the media autobuild suite: https://github.com/fraunhoferhhi/vvenc/wiki/FFmpeg-Integration#windows

However, after following the instructions and attempting multiple times, the output binary does not include VVC. I noticed during my latest attempt media-autobuild_suite was outputting these messages:

image

Perhaps I configured something wrong, but I'm not sure. I included logs and other relevant files in the attached zip. Any idea what's wrong?

vvc_testing.zip

lehmann-c commented 11 months ago

The patches are not working properly anymore.

You can set ffmpeg to the last working revision 9413bdc381 in the ini-file media-autobuild_suite/build/media-autobuild_suite.ini: ffmpegPath=https://git.ffmpeg.org/ffmpeg.git#9413bdc381

But as quite a lot of dependent packages also changed since spring 2023, it is expected that the build will fail. You can try to play around with the ffmpegPath, but if you revert the ffmpeg revision you also have to disable some packages in the file build/ffmpeg_options.txt and adapt quite a lot of revisions of dependent packages of repositories defined in build/media-suite_deps.sh

Best option is to wait for new patchset or hope that the patches will be accepted and merged into the main branch.

JohnTravolski commented 11 months ago

Aw man

lehmann-c commented 11 months ago

Good news - a new patchset for vvenc/vvdec has just been submitted. The VVenC wiki is already updated and you can give it another try with the latest ffmpeg version.

JohnTravolski commented 11 months ago

Good news - a new patchset for vvenc/vvdec has just been submitted. The VVenC wiki is already updated and you can give it another try with the latest ffmpeg version.

Awesome, I actually got it working! Although media autobuild suite was having its own set of issues and I had to disable the following in the media-autobuild_suite.ini config file:

libavif=2
jpegxl=2

and I had to disable a few things in the ffmpeg_options.txt file as well:

--disable-libplacebo
--disable-libjxl
--disable-doc

Also, ffmpeg would crash if the binary was copied over to a system without the nvidia computing toolkit installed (I compiled it on a system that did have the toolkit installed). To prevent that, I also had to include the following in ffmpeg_options:

--disable-libnpp
lehmann-c commented 10 months ago

Thanks for the feedback. I added a section in the wiki concerning media_suite troubleshooting: https://github.com/fraunhoferhhi/vvenc/wiki/FFmpeg-Integration#troubleshooting-media-autobuild-suite

adamjw24 commented 10 months ago

Thanks for reporting. Glad the issue is now resolved from our side. Closing for now