fraunhoferhhi / vvenc

VVenC, the Fraunhofer Versatile Video Encoder
https://www.hhi.fraunhofer.de/en/departments/vca/technologies-and-solutions/h266-vvc.html
BSD 3-Clause Clear License
968 stars 173 forks source link

Fix added integer int #436

Closed Jamaika1 closed 1 month ago

Jamaika1 commented 1 month ago
TrQuant.cpp: In member function 'void vvenc::TrQuant::xIT(const vvenc::TransformUnit&, vvenc::ComponentID, const CCoeffBuf&, vvenc::PelBuf&)':
TrQuant.cpp:624:33: warning: comparison of unsigned expression in '< 0' is always false [-Wtype-limits]
  624 |     CHECK((transformHeightIndex < 0), "There is a problem with the height.");
      |            ~~~~~~~~~~~~~~~~~~~~~^~~
TypeDef.h:641:32: note: in definition of macro 'CHECK'
  641 | #define CHECK(c,x)          if(c){ THROW(x); }
      |                                ^
adamjw24 commented 1 month ago

It seems a more appropriate way of fixing this would be to delete the CHECK

Jamaika1 commented 1 month ago

I understand that transformHeightIndex is never negative. I delete negative value of transformHeightIndex.