Problems with example `registration.py`

frawau / aiozeroconf

An asyncio/pure python implementation of multicast DNS service discovery

GNU Lesser General Public License v2.1

25 stars 6 forks source link

Problems with example `registration.py` #12

Closed cmcqueen closed 5 years ago

cmcqueen commented 5 years ago

I see a couple of problems with the example code registration.py:

A ServiceInfo object is created and assigned to variable info at the file level. But it seems this isn't used for anything. Another one is created in the function run_test(), and that seems to actually do something. Is this a mistake with refactoring this code?
It seems most of the ServiceInfo parameters now need to be named parameters, rather than positional.

frawau commented 5 years ago

Hi,

Thanks for your comments.

It is an example, it is just to show what you can do. By all mean, do modify things as you see fit.

Regards

cmcqueen commented 5 years ago

As the example currently is, it can't even run — since most of the ServiceInfo parameters now need to be named parameters, rather than positional. So could you please fix that? I can submit a pull request if you would like.

frawau commented 5 years ago

Hi,Those examples are remnants of some old software, I should have removed them. The one and only example is main.pyNow if you want to fix them with a PR, go ahead, I'll merge it in.Regards, FrançoisOn 15 Feb 2019 05:55, Craig McQueen notifications@github.com wrote:As the example currently is, it can't even run — since most of the ServiceInfo parameters now need to be named parameters, rather than positional. So could you please fix that? I can submit a pull request if you would like.

—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.