search

fraxiinus / ReplayBook

Play, manage, and inspect League of Legends replays
https://www.fraxiinus.dev/ReplayBook/
GNU General Public License v3.0
340 stars 53 forks source link

Ornn upgraded item icons are not shown properly #112

Closed fraxiinus closed 1 year ago

fraxiinus commented 3 years ago

Describe the bug When looking at a replay with Ornn, upgraded items will fail to download its images

To Reproduce Steps to reproduce the behavior:

  1. Click on a replay with Ornn
  2. Image will show up as missing
  3. Logs will show error

Expected behavior ReplayBook should be able to display the items

Additional context All ReplayBook knows about an item is its 'id' number. The program asks Data Dragon for the image with that item id. ReplayBook is getting a 403 Accessed Denied error when trying to get Ornn items. This is the generic error message Data Dragon returns if something doesn't exist.

It seems that at some point Ornn's items were included in the Data Dragon payload. My production system is able to display it properly, so at one point things were fine. What happened?

fraxiinus commented 1 year ago

This problem appears to be fixed after the introduction of static data bundles; which uses item sprite sheets instead of individual pngs.

Still evaluating