fraxiinus / ReplayBook

Play, manage, and inspect League of Legends replays
https://www.fraxiinus.dev/ReplayBook/
GNU General Public License v3.0
340 stars 53 forks source link

Replay search no longer requires all keywords to be present #145

Closed fraxiinus closed 1 year ago

fraxiinus commented 2 years ago

Search is now an "OR" operation on all keywords, instead of an "AND"

This is caused by this query: https://github.com/fraxiinus/ReplayBook/blob/master/src/Files/Repositories/DatabaseRepository.cs#L201

See this issue for LiteDB: https://github.com/mbdavid/LiteDB/issues/1885

fraxiinus commented 1 year ago

LiteDB is a document database, not a search provider. Perhaps I should include a solution like Lucene.Net to use for search instead.

fraxiinus commented 1 year ago

https://github.com/bleroy/lunr-core looks nice

fraxiinus commented 1 year ago

Lunr indexes are immutable, not well fit for this use case