search

fraxiinus / ReplayBook

Play, manage, and inspect League of Legends replays
https://www.fraxiinus.dev/ReplayBook/
GNU General Public License v3.0
325 stars 51 forks source link

Static data is not persisting if downloaded though context menu #203

Closed fraxiinus closed 2 years ago

fraxiinus commented 2 years ago

Report from xadamxk:

Every time my replay list includes an old patch, the assets are always broken by default UNTIL I click Get Images for Patch xx.xx . This fixes the broken asset issue temporarily until I close and reopen Replay book. Is this intended behavior or did I do something wrong?

Image

A friend poked around, since I'm not well versed with C#, and said the settings window is what has the exit handler to save items. The issue gets fixed if you open and close the settings dialogue, so the main window just needs the same exit handler logic as the settings window.

fraxiinus commented 2 years ago

Confirmed still occurring, even after changes to consolidate static data #204