search

fraxken / combine-async-iterators

Combine Asynchronous Iterators (no sequence)
MIT License
14 stars 4 forks source link

fix: `return` is an optional method of iterators #11

Closed elldritch closed 1 year ago

elldritch commented 1 year ago

This fixes an issue where iterators that do not provide the optional return method cause combine-async-iterator to crash.

For example, Octokit's pagination iterator does not provide this method.

I added tests, checked that npm test succeeded with the patch, checked that npm test failed without the patch, and ran tests in Node 12.

fraxken commented 1 year ago

@elldritch Sorry for the delay (didn't see notification). Thanks for the contribution.

Release coming soon :)

fraxken commented 1 year ago

@allcontributors please add @elldritch for bug

allcontributors[bot] commented 1 year ago

@fraxken

I've put up a pull request to add @elldritch! :tada: