Closed ShengpeiWang closed 2 years ago
@jamie-sgro in your comment, the code got copied again to the stack trace section, do you mind showing me the trace again? I also tried your code locally, and it worked fine.
@ShengpeiWang I got a max retries failure but I've tested it now and it seems to be working fine. My thought is that it was just bad timing against the live API. Gotta love being dependent on live external services like that. I'll review your code proper now that I can greenlight
@jamie-sgro, thanks for the explanation and resource pointers! I made the changes to pass around only modis_session
in 9117876. Can confirm that the code still runs as expected.
Regarding the other point, yeah I did not want to over engineer things. Given requests
is a standard library, I think it's OK to not obscure interactions with it.
Description
HTTPProxyAuth
for the first data download of a session.No file location found
, when we tried to download MOD13A2 tiles this week. When we checked the download link on the browser, the authentication request was directed tours.earthdata.nasa.gov
and can no longer be accomplished withHTTPBasicAuth
.GranuleHandler
class. I chose to pass themodis_session
object along, but I'm still thinking about whether there is a cleaner way to do it.session
object is a part of themodis_session
object, so there's currently redundant information being passed into the methods. I'm not sure if we wang to make large scale refactoring change here.GranuleHandler
vsModisSession
) should worry about the implementation detail of usingHTTPProxyAuth
. I have tried both ways, and the current version is cleaner in code and logic.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
Next Steps
[ ] Assign a reviewer based on the code owner document.
[ ] Once your review is approved, merge and delete the feature branch
On behalf of the Modis Tools Dev Team, thank you for your hard work! ✨