fraymio / modis-tools

Tools for working with the MODIS API and MODIS data.
Apache License 2.0
23 stars 12 forks source link

Investigating pydantic v2 upgrade #40

Closed iamchrisearle closed 8 months ago

iamchrisearle commented 1 year ago

Description

Experimental branch showing known issues with updating to pydantic V2

Closes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Checklist:

Next Steps

On behalf of the Modis Tools Dev Team, thank you for your hard work! ✨

iamchrisearle commented 10 months ago

For when we do upgrade to higher pydantic versions, this fix will help with coercing the URL to behave like a string:

https://github.com/pydantic/pydantic/issues/7186#issuecomment-1874338146

jamie-sgro commented 8 months ago

@cearlefraym what's the status of this PR?

iamchrisearle commented 8 months ago

@cearlefraym what's the status of this PR?

This is for knowledge transfer, it can be closed. If/when switching to pydantic v2, this is important behavior to need to build around.