Ds 6157 url issue with modisa l3b chl ms

[mylesstokowski]

Description

This PR is based on #41 and contains:

• a refactor to use Pydantic models to fix the broken URLs (hopefully more concise)
• tests proving that the fix works

Closes # (issue)

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

• [x] pytest should greenlight. You could read through the tests and/or poke around with a debugger
• [ ] @cearlefraym's testing script should still work, i.e. python test.py. NOTE that we should remove this and any other extra testing files before merging to main.

Checklist:

• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules
• [ ] I have checked my code and corrected any misspellings

Next Steps

• [ ] Assign a reviewer based on the code owner document.

• [ ] Once your review is approved, merge and delete the feature branch

On behalf of the Modis Tools Dev Team, thank you for your hard work! ✨

[mylesstokowski]

Should we also include the always arg?

Interesting, I wasn't familiar. I tried adding that parameter, and didn't observe any chance in behavior. I tested by running test_space_is_removed_from_link() as is and with the href field removed in the input. Since it's working now, I'm tempted to leave it as is.

[mylesstokowski]

Thanks for the review @cearlefraym! One q: any preference whether I merge this into your base branch, then merge that to main, or alternatively switch the base branch to main and merge it directly?

And relatedly, confirming there's no special approval process for this repo (i.e., confirming that we don't need another approval to merge to main)?

[mylesstokowski]

@cearlefraym I pointed it to main, reviewed the changes in your branch, made a couple suggestions, and removed the test file. Take a look, then I'll test once more and merge.