Issue 3 change updated to optional in api entry

ShengpeiWang commented 2 years ago

Description

made updated optional in ApiEntry
add National Snow and Ice Data Center as a datasource
reverted 898fa80 in b97ed66. The reason for 898fa80: to allow for the successful download of non-modis data. since the get request response headers don't contain "Location". I noted in the docstring that this flag is experimental, since I did not test it using any datasource other than NSIDC

Closes #3

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] pytest
[x] tested that local downloads succeed with the README example: "MOD13A1"
[x] tested that local downloads succeed with the example from the issue #3 : "MOD10A1"

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Next Steps

[ ] Assign a reviewer based on the code owner document.
[ ] Once your review is approved, merge and delete the feature branch

On behalf of the Modis Tools Dev Team, thank you for your hard work! ✨

ShengpeiWang commented 2 years ago

Request error during data download as of 898fa80. @jtanwk and I figured out the issue: the download_cookies have different data structures for the modis vs the nsidc data. We got successful data download from both sources once we changed the has_download_cookies method by removing the lines: data = cookies["DATA"] assert data.domain == URLs.RESOURCE.value Next step: Check with original contributors and other code owners about how to proceed with the fix.

jtanwk commented 2 years ago

Additional note: cookie name for NSIDC is "CIsforCookie_OPS" whereas it is "DATA" for LP DAAC-sourced data.

Extra documentation probably required for future updates if we want to add other DAACs/data sources.

jamie-sgro commented 2 years ago

@ShengpeiWang Status update on this?

ShengpeiWang commented 2 years ago

@ShengpeiWang Status update on this?

nothing right now

iamchrisearle commented 2 years ago

MOD10A1 download works now. LGTM

fraymio / modis-tools